Log in

Forum:Heading underline not ending where it should

From PathfinderWiki
Forums: Workshop > Heading underline not ending where it should

Horizontal lines that are generated as part of type 2 section headings are passing through infoboxes ans thumbnails within articles. An example can be seen on the article Devilfish, under the Variant Devilfish section heading.

Re: Section underlining. It's not so much that the underline extends (it's always there), rather, the boxes it appears to pass through have no background colour set. Splitting hairs of course, we'll still have to fix it.

Re: Section underlining

Actually, the section underline has always stopped short of a thumbnail image, rather than continuing beneath it. This was the case not only on Wikia, but before we moved there. I'm not sure what the problem is with thumbnails currently, but it might be linked to lack of right-sided margins.

Traditionally, thumbnails are coded to automatically apply a margin around their border, to cause article text to wrap before running up against it. Currently, our thumbnails do not seem to include such a margin, and I'm wondering if it was also the margin that used to prevent section underlines from continuing past the image borders as well. I don't know how to define such a margin, but it might be something worth looking into.

Hmm. OK, does look the way you expect?
Hey, this is Brandingopportunity. I'm having trouble logging into the wiki for some unknown reason. When I log in anonymously, it's not a problem, but when I try to log in, it forwards me to a blank page. Any idea what might be causing this?
Whoops, I think that was me. Try it now.
yup, that fixed it
Whatever you did fixed it! Thank you. Also, belated kudos again for all the work people have been putting in here. Just got back from a weekend out of town and the wiki looks a lot better

Nah, I'm totally unfamiliar with Wikipedia's new skin. I recall something like you see on WoWPedia.

Yeah, that's the skin I was thinking of. It's more modern looking than monobook, but not overkill like oasis or even monaco.
@Heavens Agent, huh that's interesting. WoWpedia is using a modified version of Vector which is the skin that Wikipedia uses (and is the default as of MediaWiki 1.16). Apparently, amongst the things they modified is how the heading underlines behave. I'll have a look and see if I can figure out what they've changed.

As for Yoda8myhead liking the overall look of Vector/WoWpedia, I can't say that I disagree. I don't know if we can backport it to MediaWiki 1.15 (which is what we're using), but we can almost certainly modify a copy of monobook to closly emulate it. That conversation is probably better had over here though.

Hmm, that's kind of an interesting cheat that they did. It's actually a thick border the same colour as the background. Having a graphical background on our articles, we can't really use that technique (perhaps something we should discuss).

It's not something unique to vector. If you view sites such as WoWPedia in Monobook, the same break in the section underline appears. I do believe it is something specific to the formatting of thumbnails themselves.

Oh, yeah, no. I didn't mean that it was a trick of the Vector skin (in fact the Wikipedia fox article illustrates a line right up to the thumbnail border). I can also confirm that their monobook skin uses the same trick to "hide" the heading underline. At any rate, the technique they use to achieve the effect won't work for us right now since it doesn't actually stop the line from extending, but rather hides it. When I hit "save" here, I'm going to fix our stylesheets up so that the line doesn't appear to extend through the box. After that we'll have to discuss whether getting rid of the "paper" background is something we want to do (which would allow us to seamlessly hide the heading underlines like WoWpedia does).